Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods support #38

Merged
merged 2 commits into from
Dec 8, 2017
Merged

Cocoapods support #38

merged 2 commits into from
Dec 8, 2017

Conversation

gsampaio
Copy link
Contributor

@gsampaio gsampaio commented Dec 1, 2017

I've been playing with your library and it's awesome. I have added support for cocoapods in order to be able to play around with it in my iOS project. I know it's still in early development and the API may change a lot before been stable, this is just the initial implementation.

Lastly I still have two warnings while running pod lib lint SnapshotTesting.podspec --verbose, and I don't know how to fix it right now. Any help would be appreciated

** BUILD SUCCEEDED **

   Testing with xcodebuild. 
 -> SnapshotTesting (0.1.0)
    - NOTE  | xcodebuild:  <module-includes>:1:9: note: in file included from <module-includes>:1:
    - NOTE  | xcodebuild:  /privateTarget Support Files/SnapshotTesting/SnapshotTesting-umbrella.h:13:9: note: in file included from /privateTarget Support Files/SnapshotTesting/SnapshotTesting-umbrella.h:13:
    - WARN  | xcodebuild:  /Users/guilhermesampaio/Dev/OSS/swift-snapshot-testing/Sources/WKSnapshotConfigurationShim/include/WKSnapshotConfigurationShim.h:2:2: warning: missing submodule 'WebKit.WKSnapshotConfiguration'
    - NOTE  | xcodebuild:  /Users/guilhermesampaio/Library/Developer/Xcode/DerivedData/App-ghdrndgqqxoolwbxhjjzystbddvp/Build/Products/Release-iphonesimulator/SnapshotTesting/SnapshotTesting.framework/Headers/SnapshotTesting-umbrella.h:13:9: note: in file included from /Users/guilhermesampaio/Library/Developer/Xcode/DerivedData/App-ghdrndgqqxoolwbxhjjzystbddvp/Build/Products/Release-iphonesimulator/SnapshotTesting/SnapshotTesting.framework/Headers/SnapshotTesting-umbrella.h:13:
    - WARN  | xcodebuild:  /Users/guilhermesampaio/Library/Developer/Xcode/DerivedData/App-ghdrndgqqxoolwbxhjjzystbddvp/Build/Products/Release-iphonesimulator/SnapshotTesting/SnapshotTesting.framework/Headers/WKSnapshotConfigurationShim.h:2:2: warning: missing submodule 'WebKit.WKSnapshotConfiguration'

Thanks for all the work on it.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks so much for contributing!

I'm not sure those warnings can be avoided right now. Apple forgot to expose a header for WebKit snapshots in the latest release 😨

I'm not a CocoaPods expert, so I'm not sure if there's a way of splitting a pod into multiple modules the way SPM does (if so, we could avoid maintaining the #if COCOAPODS logic), but this looks like a good solution if not!

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

I too am curious of cocoapods allows a single repo to house many pods, but I'm not familiar enough with this stuff. down to merge as-is tho!

@stephencelis stephencelis merged commit ea4f027 into pointfreeco:master Dec 8, 2017
@stephencelis
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants