Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Ran gosimports on the entire repo #758

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

Olshansk
Copy link
Member

Description

Grouped all the imports using gosimports.

Issue

Fixes #185

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Added gosimports as a makefile helper (make go_imports) and to the installation tools
  • Added goimports as a linter config file
  • Ran go_imports on everything

Testing

  • make develop_test; if any code changes were made
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@Olshansk Olshansk added core Core infrastructure - protocol related code health Nice to have code improvement medium labels May 17, 2023
@Olshansk Olshansk requested a review from okdas May 17, 2023 02:01
@Olshansk Olshansk self-assigned this May 17, 2023
Copy link
Member

@okdas okdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I re-ran the test and it came back green.

@Olshansk Olshansk merged commit f05735f into main May 17, 2023
@Olshansk Olshansk deleted the issues_185/imports2 branch May 17, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement core Core infrastructure - protocol related waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Automation] Add make targets to group imports
2 participants