Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Refactor test helpers #797

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wip: testutils
  • Loading branch information
bryanchriswhite committed Jun 1, 2023
commit 0a27fadc6f2671cc009c220cbf14ea8eb77b62a6
2 changes: 1 addition & 1 deletion internal/testutil/keys.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func LoadLocalnetPrivateKeys(t require.TestingT, keyCount int) (privKeys []crypt

privKeys = make([]cryptoPocket.PrivateKey, 0, keyCount)

// scann through file & extract private keys
// scan through file & extract private keys
scanner := bufio.NewScanner(privKeyManifest)
scanner.Split(bufio.ScanLines)

Expand Down
27 changes: 22 additions & 5 deletions internal/testutil/telemetry/mocks.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package telemetry_testutil

import (
"github.com/golang/mock/gomock"
"github.com/pokt-network/pocket/internal/testutil"
"github.com/regen-network/gocuke"

"github.com/pokt-network/pocket/shared/modules"
Expand All @@ -17,13 +18,20 @@ func MinimalTelemetryMock(
ctrl := gomock.NewController(t)
telemetryMock := mock_modules.NewMockTelemetryModule(ctrl)

busMock.EXPECT().GetTelemetryModule().Return(telemetryMock).AnyTimes()

return telemetryMock
}

func BehavesLikeBaseTelemetryMock(
t gocuke.TestingT,
telemetryMock *mock_modules.MockTelemetryModule,
) *mock_modules.MockTelemetryModule {
t.Helper()

telemetryMock.EXPECT().Start().Return(nil).AnyTimes()
telemetryMock.EXPECT().SetBus(gomock.Any()).Return().AnyTimes()
// TODO_THIS_COMMIT: which one ^ v ?
//telemetryMock.EXPECT().SetBus(busMock).Return().AnyTimes()
telemetryMock.EXPECT().GetModuleName().Return(modules.TelemetryModuleName).AnyTimes()
busMock.EXPECT().GetTelemetryModule().Return(telemetryMock).AnyTimes()
//busMock.RegisterModule(telemetryMock)

return telemetryMock
}
Expand All @@ -33,7 +41,16 @@ func BaseTelemetryMock(
busMock *mock_modules.MockBus,
) *mock_modules.MockTelemetryModule {
t.Helper()
return WithTimeSeriesAgent(t, WithEventMetricsAgent(t, MinimalTelemetryMock(t, busMock)))

return testutil.PipeTwoToOne[
gocuke.TestingT,
*mock_modules.MockTelemetryModule
](
t, MinimalTelemetryMock(t, busMock),
BehavesLikeBaseTelemetryMock,
WithEventMetricsAgent,
WithTimeSeriesAgent,
)
}

func WithTimeSeriesAgent(
Expand Down