Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Metrics revamp #901

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

okdas
Copy link
Member

@okdas okdas commented Jul 12, 2023

Description

Fixing existing and adding new metrics.

Summary generated by Reviewpad on 12 Jul 23 20:53 UTC

This pull request adds a dummy file named "tmp" to kickoff devnet. The file has no content changes.

Issue

Fixes #606

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@okdas okdas added the e2e-devnet-test Runs E2E tests on devnet label Jul 12, 2023
@okdas okdas self-assigned this Jul 12, 2023
@reviewpad reviewpad bot added the small Pull request is small label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-devnet-test Runs E2E tests on devnet small Pull request is small
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Telemetry] Standardize and add metrics
1 participant