Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][IBC] Implement ICS-02 Client Semantics #916

Draft
wants to merge 23 commits into
base: ibc/proto-exploration-ics23
Choose a base branch
from
Draft

[WIP][IBC] Implement ICS-02 Client Semantics #916

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
58a78c1
Create ClientManager interface and Client interface definitions
h5law Jul 11, 2023
fec79d1
Use current height for read context and pass uint64 heights into getters
h5law Jul 14, 2023
9c2af75
Remove Height field from IBCEvent proto definition
h5law Jul 14, 2023
227e526
Add emit event functions for the client submodule
h5law Jul 14, 2023
ec954e7
Implement CreateClient method
h5law Jul 14, 2023
04d969d
Implement UpdateClient method
h5law Jul 14, 2023
37e2ee3
Implement UpgradeClient method
h5law Jul 17, 2023
8425f83
Shorted log lines
h5law Jul 17, 2023
3eff80b
Add WASM specific implementations for client interfaces
h5law Jul 17, 2023
99423a8
Allow setting nil keys
h5law Jul 18, 2023
4bd3d41
Add error returns
h5law Jul 18, 2023
7718b9c
Use clientID prefixed client store
h5law Jul 18, 2023
fcc11ad
Add Wasm Client protobuf implementations
h5law Jul 18, 2023
1a29904
Add Pocket specific Client and Consensus State types
h5law Jul 18, 2023
92236b3
Allow host introspection of its own ConsensusState
h5law Jul 18, 2023
ddccdd0
Add GetHostClientState()
h5law Jul 19, 2023
9f7f2bb
Add VerifyHostClientState method
h5law Jul 20, 2023
93e71e8
Add nolint lines for unused types
h5law Jul 18, 2023
f3a4b56
Add ICS-02 documentation
h5law Jul 20, 2023
6380ee1
Add client query tests
h5law Jul 21, 2023
8cfd9af
Add basic type tests
h5law Jul 21, 2023
f61c97a
Add host client introspection tests
h5law Jul 21, 2023
7e61c5d
fix linter error
h5law Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use clientID prefixed client store
  • Loading branch information
@h5law
h5law committed Jul 24, 2023
commit 7718b9c7759346d9c957f80a3389824940a50ce7
26 changes: 18 additions & 8 deletions ibc/client/submodule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package client
import (
"fmt"

"github.com/pokt-network/pocket/ibc/client/types"
"github.com/pokt-network/pocket/ibc/path"
core_types "github.com/pokt-network/pocket/shared/core/types"
"github.com/pokt-network/pocket/shared/modules"
Expand All @@ -15,7 +16,7 @@ var (
)

func init() {
allowedClientTypes["08-wasm"] = struct{}{}
allowedClientTypes[types.WasmClientType] = struct{}{}
}

type clientManager struct {
Expand Down Expand Up @@ -67,8 +68,9 @@ func (c *clientManager) CreateClient(
// Generate a unique identifier for the client
identifier := path.GenerateClientIdentifier()

// Retrieve the client store
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(path.KeyClientStorePrefix)
// Retrieve the client store prefixed with the client identifier
prefixed := path.ApplyPrefix(core_types.CommitmentPrefix(path.KeyClientStorePrefix), identifier)
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(string(prefixed))
if err != nil {
return "", err
}
Expand Down Expand Up @@ -105,8 +107,9 @@ func (c *clientManager) UpdateClient(
return err
}

// Get the client store
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(path.KeyClientStorePrefix)
// Retrieve the client store prefixed with the client identifier
prefixed := path.ApplyPrefix(core_types.CommitmentPrefix(path.KeyClientStorePrefix), identifier)
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(string(prefixed))
if err != nil {
return err
}
Expand Down Expand Up @@ -138,7 +141,13 @@ func (c *clientManager) UpdateClient(
}

// Update the client
consensusHeight := clientState.UpdateState(clientStore, clientMessage)
consensusHeight, err := clientState.UpdateState(clientStore, clientMessage)
if err != nil {
c.logger.Error().Err(err).Str("identifier", identifier).
Str("height", consensusHeight.ToString()).
Msg("failed to update client state")
return err
}
c.logger.Info().Str("identifier", identifier).
Str("height", consensusHeight.ToString()).
Msg("client state updated")
Expand Down Expand Up @@ -167,8 +176,9 @@ func (c *clientManager) UpgradeClient(
return err
}

// Get the client store
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(path.KeyClientStorePrefix)
// Retrieve the client store prefixed with the client identifier
prefixed := path.ApplyPrefix(core_types.CommitmentPrefix(path.KeyClientStorePrefix), identifier)
clientStore, err := c.GetBus().GetIBCHost().GetProvableStore(string(prefixed))
if err != nil {
return err
}
Expand Down