ci: Fix GH publish (#27)

pola-rs · Oct 12, 2023 · fd08cd5 · fd08cd5
1 parent 41f3b86
commit fd08cd5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml
@@ -5,6 +5,11 @@ on:
     branches:
       - main
   workflow_dispatch:
+    inputs:
+      # Latest commit to include with the release. If omitted, use the latest commit on the main branch.
+      sha:
+        description: Commit SHA
+        type: string
 
 permissions:
   contents: write
@@ -18,6 +23,7 @@ jobs:
         uses: release-drafter/release-drafter@v5
         with:
           config-name: release-drafter.yml
+          commitish: ${{ inputs.sha }}
           disable-autolabeler: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -152,8 +152,7 @@ jobs:
           name: binaries
           path: binaries
 
-      # TODO: Publish only after uploading binaries
-      - name: Create and publish GitHub release
+      - name: Create GitHub release
         id: github-release
         uses: release-drafter/release-drafter@v5
         with:
@@ -163,15 +162,20 @@ jobs:
           version: ${{ needs.get-version.outputs.version }}
           prerelease: ${{ needs.get-version.outputs.is-prerelease }}
           commitish: ${{ inputs.sha }}
-          publish: ${{ inputs.dry-run == false }}
           disable-autolabeler: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Upload binaries to GitHub release
-        uses: svenstaro/upload-release-action@v2
-        with:
-          file: binaries/*
-          file_glob: true
-          tag: ${{ steps.github-release.outputs.tag_name }}
-          overwrite: true
+        run: gh release upload $TAG $FILES --clobber
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TAG: ${{ steps.github-release.outputs.tag_name }}
+          FILES: binaries/*
+
+      - name: Publish GitHub release
+        if: inputs.dry-run == false
+        run: gh release edit $TAG --draft=false
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          TAG: ${{ steps.github-release.outputs.tag_name }}