Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterable groupby_rolling and groupby_dynamic #5786

Closed
StijnKas opened this issue Dec 12, 2022 · 1 comment · Fixed by #6372
Closed

Iterable groupby_rolling and groupby_dynamic #5786

StijnKas opened this issue Dec 12, 2022 · 1 comment · Fixed by #6372
Assignees
@stinodego
Labels
enhancement New feature or an improvement of an existing feature

Comments

@StijnKas
Copy link

Problem description

groupby has an __iter__ method defined, making it quite easy to iteratively work through the groups for debugging. Although for production of course you'd just use .agg, it would be nice if groupby_rolling and groupby_dynamic also had an __iter__ method.
@StijnKas StijnKas added the enhancement New feature or an improvement of an existing feature label Dec 12, 2022
@stinodego
Copy link
Member

stinodego commented Jan 4, 2023 •
edited
Loading

I have just revised the iterator for the regular GroupBy (see #5786) - if that gets merged we can probably implement something similar for RollingGroupBy and DynamicGroupBy.

@stinodego stinodego mentioned this issue Jan 5, 2023
Closed
@stinodego stinodego self-assigned this Jan 19, 2023
@stinodego stinodego mentioned this issue Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
enhancement New feature or an improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(python): Make groupby rolling/dynamic iterable stinodego/polars
2 participants
@stinodego @StijnKas