-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Format null arrays in Series #11289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovacca
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
September 24, 2023 21:29
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
rust
Related to Rust Polars
labels
Sep 24, 2023
CI failures seem unrelated? |
Can you rebase based on |
Yeah i was fighting with that, never used rebase before. Should be good now! |
c-peters
reviewed
Sep 29, 2023
|
ritchie46
approved these changes
Oct 2, 2023
Thank you @romanovacca. Looks better indeed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7153
null array now is shown as:
instead of
Could refactor the code a bit cause it overlaps with
format_array
a lot, so there is quite some repitition, but made this PR to see if this is in the right direction at all.