fix: fix project pushdown for double projection contains count #11843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
reswqa
commented
Oct 19, 2023
| @@ -29,6 +54,14 @@ pub(super) fn process_projection( | |||
| // simply select the first column | |||
| let (first_name, _) = input_schema.try_get_at_index(0)?; | |||
| let expr = expr_arena.add(AExpr::Column(Arc::from(first_name.as_str()))); | |||
| if !acc_projections.is_empty() { | |||
There was a problem hiding this comment.
I'm not sure would it be more reasonable to clear acc_projections and projected_names directly here? Because we seem to be only concerned with the first input. 🤔
There was a problem hiding this comment.
Yes, good point. We could immediately move those to the "local" projection.
There was a problem hiding this comment.
oops, if we immediately move all acc_projections to local projection.
pl.LazyFrame({"x" : 1}).select(pl.count().alias("r")).select(pl.col("r")).collect()Will panic durning build local_projections as we push down pl.col("r") to the first select.
PanicException: called `Result::unwrap()` on an `Err` value: ColumnNotFound(ErrString("r"))There was a problem hiding this comment.
Ok, let's leave it like this. It seems pretty clean now. :)
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
ritchie46
approved these changes
Oct 20, 2023
| @@ -29,6 +54,14 @@ pub(super) fn process_projection( | |||
| // simply select the first column | |||
| let (first_name, _) = input_schema.try_get_at_index(0)?; | |||
| let expr = expr_arena.add(AExpr::Column(Arc::from(first_name.as_str()))); | |||
| if !acc_projections.is_empty() { | |||
There was a problem hiding this comment.
Ok, let's leave it like this. It seems pretty clean now. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11841.