fix: rolling_* aggs were behaving as if they return scalars in group-by #15657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
MarcoGorelli
changed the title
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
CodSpeed Performance ReportMerging #15657 will not alter performanceComparing Summary
|
ritchie46
approved these changes
Apr 15, 2024
| @@ -1208,7 +1208,7 @@ impl Expr { | |||
| self.apply_many_private( | |||
| FunctionExpr::RollingExpr(rolling_function_by(options)), | |||
| &[col(&name)], | |||
| true, | |||
| false, | |||
There was a problem hiding this comment.
Ai, good catch. That took a long time.
There was a problem hiding this comment.
Just wondering what's the principle here, it seems to be the same behavior for reduce/fold (return_scalars=True).
There was a problem hiding this comment.
Rolling functions return something which is the same length as the input, so I don't think they should ever return a scalar
There was a problem hiding this comment.
Yeap, I see. But IIRC, the output of fold/reduce should also be consistent with the length of the input.
There was a problem hiding this comment.
ah thanks - will take a look, have made a note-to-self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15656