Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panic if invalid array in object #15664

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: Panic if invalid array in object #15664

merged 1 commit into from
Apr 15, 2024

Conversation

ritchie46
Copy link
Member

#15237

Doesn't fix the culprit, but at leasts panicks now.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 15, 2024
Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #15664 will not alter performance

Comparing panic (72698c5) with main (f992a7a)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.31%. Comparing base (99ab9c0) to head (72698c5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15664   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files        1373     1373           
  Lines      176254   176256    +2     
  Branches     2544     2544           
=======================================
+ Hits       143320   143323    +3     
  Misses      32452    32452           
+ Partials      482      481    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1faf932 into main Apr 15, 2024
20 checks passed
@ritchie46 ritchie46 deleted the panic branch April 15, 2024 13:25
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants