Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove outdated join validation checks #15701

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

ritchie46
Copy link
Member

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.34%. Comparing base (8befcd1) to head (c0833e9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15701      +/-   ##
==========================================
- Coverage   81.34%   81.34%   -0.01%     
==========================================
  Files        1375     1375              
  Lines      176532   176564      +32     
  Branches     2544     2544              
==========================================
+ Hits       143604   143618      +14     
- Misses      32445    32462      +17     
- Partials      483      484       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15701 will not alter performance

Comparing join_validation (c0833e9) with main (2ac0da2)

Summary

✅ 22 untouched benchmarks

@ritchie46 ritchie46 merged commit 6253095 into main Apr 17, 2024
26 checks passed
@ritchie46 ritchie46 deleted the join_validation branch April 17, 2024 06:11
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants