Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use two binary searches for equality mask when data is sorted #15702

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Apr 16, 2024

Fixes #11805.

Currently only works if there are no nulls in the data, and only for primitive types (no strings / nested data).

Also only works for broadcasting equality, not Series == Series.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 16, 2024
Copy link

codspeed-hq bot commented Apr 16, 2024

CodSpeed Performance Report

Merging #15702 will not alter performance

Comparing orlp:binary-search-eq-comparison (5a0de41) with main (2ac0da2)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (99ab9c0) to head (5a0de41).
Report is 31 commits behind head on main.

Files Patch % Lines
...polars-core/src/chunked_array/comparison/scalar.rs 92.68% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15702      +/-   ##
==========================================
+ Coverage   81.31%   81.34%   +0.03%     
==========================================
  Files        1373     1375       +2     
  Lines      176254   176608     +354     
  Branches     2544     2544              
==========================================
+ Hits       143320   143666     +346     
- Misses      32452    32458       +6     
- Partials      482      484       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ff3feaa into pola-rs:main Apr 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fast path for filtering on a sorted column
2 participants