-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rust): Factor out ensure_is_constant_duration
#15733
chore(rust): Factor out ensure_is_constant_duration
#15733
Conversation
CodSpeed Performance ReportMerging #15733 will improve performances by 14.83%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracting this logic is a good move if it will be reused 👍 Though I would generally expect that as part of the PR that actually introduces the duplication. After this PR I could look at the code base and think: let's remove this method as it's only used in 1 place. So in this case I would recommend to just include this in the PR you linked.
Duration.ensure_is_constant_duration
Duration.ensure_is_constant_duration
thanks for your review!
That's a fair point - in this case, the discussion in 12597/files has been going on for a while, so I didn't really want to clutter it too much |
Good to go if CI is green! |
Duration.ensure_is_constant_duration
ensure_is_constant_duration
This would enable deduping a few things in https://github.com/pola-rs/polars/pull/12597/files