Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect is_between pushdown to scan_pyarrow_dataset #15769

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #15765

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 19, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct to me, thanks!

Copy link

codspeed-hq bot commented Apr 19, 2024

CodSpeed Performance Report

Merging #15769 will not alter performance

Comparing nameexhaustion:pya (fa64234) with main (0423fa3)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (0c2783a) to head (fa64234).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15769   +/-   ##
=======================================
  Coverage   81.35%   81.36%           
=======================================
  Files        1379     1379           
  Lines      176619   176700   +81     
  Branches     2544     2542    -2     
=======================================
+ Hits       143686   143765   +79     
- Misses      32449    32451    +2     
  Partials      484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review April 19, 2024 11:18
@stinodego stinodego changed the title fix: Incorrect is_between pushdown to scan_pyarrow_dataset fix: Fix incorrect is_between pushdown to scan_pyarrow_dataset Apr 19, 2024
@stinodego stinodego merged commit cbf7266 into pola-rs:main Apr 19, 2024
25 checks passed
@nameexhaustion nameexhaustion deleted the pya branch April 19, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is_between push down implementation in scan_pyarrow_dataset is wrong ('<' and '>' signs are exchanged)
2 participants