-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Expose plan and expression nodes through NodeTraverser
to Python
#15776
Conversation
CodSpeed Performance ReportMerging #15776 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wence-.
I think going via the free function is fine for now as long as we don't expose it further than the visitor. I've left one comment, other than that looks fine to me. 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15776 +/- ##
==========================================
- Coverage 81.29% 80.68% -0.61%
==========================================
Files 1381 1370 -11
Lines 176876 176046 -830
Branches 3043 2530 -513
==========================================
- Hits 143789 142045 -1744
- Misses 32604 33527 +923
+ Partials 483 474 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b766402
to
db04177
Compare
Cool, shall we get this in? |
Yes, I think this is good to go. Note it's currently targetted at |
Oh, yeah, let's target to |
NodeTraverser
to PythonNodeTraverser
to Python
Rather than rewriting the entire expression, allow the user to add some expressions to the existing arena and wire in an indirection map for view_expression_node.
0afbe5a
to
d2912dd
Compare
…` to Python (pola-rs#15776) Co-authored-by: ritchie <ritchie46@gmail.com>
This is a (reasonably complete) exposing of the
IR
andAExpr
enums via#[pyclass]
structs to Python.The best place to start a review is probably
visitor/nodes.rs
(theexpr_nodes.rs
wrapping of expressions follows the same pattern, but there are more structs to go through). I am reasonably happy with the structure, but not fully up-to-speed on the most idiosyncratic ways of doing things. For example, should I implementToPyObject
forWrap<&IR>
rather than having aninto_py
free function?