-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add a low-friction sql
method for DataFrame and LazyFrame
#15783
feat(python): Add a low-friction sql
method for DataFrame and LazyFrame
#15783
Conversation
sql
DataFrame/LazyFrame methodsql
method for DataFrame and LazyFrame
CodSpeed Performance ReportMerging #15783 will not alter performanceComparing Summary
|
Makes a lot of sense to be able to execute SQL queries directly on a frame! Very happy with this addition. I'll put on my nitpick hat and go through this a bit later, but definitely a good move in my opinion👍 |
c9f34cd
to
7faceb9
Compare
Fixing the failing test and further ensuring float-type parsing is even more conformant with PostgreSQL - been reading their float1 documentation in more detail and spotted some notes about "float(n)" definition 👀 Footnotes |
9e9d3c4
to
91554c9
Compare
2f31620
to
dba1409
Compare
dba1409
to
19af4fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15783 +/- ##
==========================================
- Coverage 81.37% 80.39% -0.98%
==========================================
Files 1379 1264 -115
Lines 176843 165428 -11415
Branches 2543 0 -2543
==========================================
- Hits 143908 133001 -10907
+ Misses 32452 32427 -25
+ Partials 483 0 -483 ☔ View full report in Codecov by Sentry. |
9012d24
to
1bd92d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I don't think it contains anything controversial, so I will go on and merge this. ;)
Love the functionality!
Introduces a new
sql()
method for both DataFrame and LazyFrame. Makes use ofSQLContext
internally, streamlining the usage of ad-hoc SQL on individual frames.Features
Also
::float4
(32bit) and::float8
(64bit) and::float(n)
(adaptive).::timestamp(n)
precision modifiers (1-6).