Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Extend docstring examples for asof_join #15810

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

NedJWestern
Copy link
Contributor

See #9045. I'm not sure which country, if any, was used for the original example, but Germany seems close. I haven't included examples for by_left and by_right as it doesn't seem necessary.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.39%. Comparing base (56dda21) to head (24c0576).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15810      +/-   ##
==========================================
- Coverage   80.40%   80.39%   -0.01%     
==========================================
  Files        1264     1264              
  Lines      165423   165423              
==========================================
- Hits       133011   132996      -15     
- Misses      32412    32427      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good to have this example

If you ran it locally and it renders fine, then the content looks good to me

@ritchie46 ritchie46 merged commit 1834aea into pola-rs:main Apr 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants