Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Refine interaction of "schema_overrides" with read_excel when using "calamine" engine #15827

Merged

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Apr 22, 2024

Fixes a potential edge-case where values that appear to be all-integer (but are explicitly designated as float in "schema_overrides") are converted back to integer instead of respecting the override.

Added suitable/new test coverage.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Apr 22, 2024
@alexander-beedie alexander-beedie added the A-io-excel Area: reading/writing Excel files label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (a078d0c) to head (f44dc76).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15827   +/-   ##
=======================================
  Coverage   80.38%   80.38%           
=======================================
  Files        1263     1263           
  Lines      165351   165368   +17     
=======================================
+ Hits       132910   132932   +22     
+ Misses      32441    32436    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie changed the title fix(python): Refine interaction of "schema_overrides" with read_excel "calamine" engine fix(python): Refine interaction of "schema_overrides" with read_excel when using "calamine" engine Apr 22, 2024
@ritchie46 ritchie46 merged commit e15c244 into pola-rs:main Apr 24, 2024
17 checks passed
@alexander-beedie alexander-beedie deleted the refine-calamine-dtype-inference branch April 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-excel Area: reading/writing Excel files fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants