Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dynamic literals to ensure schema correctness #15832

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Conversation

ritchie46
Copy link
Member

We should not make any (early) assumptions on values of python integers and floats. So we create dynamically typed variants of them and materialize the concrete types once we determine the schema.

@ritchie46 ritchie46 changed the title WIP: feat: Add dynamic literals to ensure schema correctness feat: Add dynamic literals to ensure schema correctness Apr 24, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 83.73383% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 74.72%. Comparing base (a078d0c) to head (283fc5e).
Report is 11 commits behind head on main.

Files Patch % Lines
...an/src/logical_plan/optimizer/type_coercion/mod.rs 89.41% 20 Missing ⚠️
crates/polars-core/src/datatypes/dtype.rs 36.00% 16 Missing ⚠️
crates/polars-sql/src/sql_expr.rs 25.00% 12 Missing ⚠️
...src/logical_plan/optimizer/type_coercion/binary.rs 75.60% 10 Missing ⚠️
...s-plan/src/logical_plan/optimizer/simplify_expr.rs 30.76% 9 Missing ⚠️
crates/polars-core/src/utils/supertype.rs 92.64% 5 Missing ⚠️
crates/polars-core/src/datatypes/field.rs 50.00% 3 Missing ⚠️
crates/polars-plan/src/logical_plan/format.rs 25.00% 3 Missing ⚠️
crates/polars-plan/src/logical_plan/lit.rs 90.32% 3 Missing ⚠️
crates/polars-core/src/datatypes/_serde.rs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15832      +/-   ##
==========================================
- Coverage   80.38%   74.72%   -5.66%     
==========================================
  Files        1263     1358      +95     
  Lines      165351   167766    +2415     
  Branches        0     3032    +3032     
==========================================
- Hits       132910   125358    -7552     
- Misses      32441    41922    +9481     
- Partials        0      486     +486     
Flag Coverage Δ
python 74.72% <83.73%> (?)
rust 71.69% <83.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 71495eb into main Apr 24, 2024
25 checks passed
@ritchie46 ritchie46 deleted the dyn_type branch April 24, 2024 14:22
@c-peters c-peters added the accepted Ready for implementation label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants