-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dynamic literals to ensure schema correctness #15832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
April 22, 2024 15:24
ritchie46
changed the title
WIP: feat: Add dynamic literals to ensure schema correctness
feat: Add dynamic literals to ensure schema correctness
Apr 24, 2024
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
Apr 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15832 +/- ##
==========================================
- Coverage 80.38% 74.72% -5.66%
==========================================
Files 1263 1358 +95
Lines 165351 167766 +2415
Branches 0 3032 +3032
==========================================
- Hits 132910 125358 -7552
- Misses 32441 41922 +9481
- Partials 0 486 +486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritchie46
commented
Apr 24, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not make any (early) assumptions on values of python integers and floats. So we create dynamically typed variants of them and materialize the concrete types once we determine the schema.