perf: Ensure we hit specialized gather for binary/strings #15886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
ritchie46
commented
Apr 25, 2024
| @@ -23,7 +23,7 @@ impl Add for &StringChunked { | |||
| type Output = StringChunked; | |||
|
|
|||
| fn add(self, rhs: Self) -> Self::Output { | |||
| unsafe { (self.as_binary() + rhs.as_binary()).to_string() } | |||
| unsafe { (self.as_binary() + rhs.as_binary()).to_string_unchecked() } | |||
There was a problem hiding this comment.
drive by. Make clear that we don't check on conversion.
CodSpeed Performance ReportMerging #15886 will improve performances by 20.77%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15886 +/- ##
==========================================
- Coverage 81.33% 81.32% -0.02%
==========================================
Files 1385 1385
Lines 177003 177014 +11
Branches 3033 3033
==========================================
- Hits 143971 143952 -19
- Misses 32547 32577 +30
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gather by slices accidentally hit the generic gather. This is very expensive for binary/string views as all buffers get naively added.
#15847