Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ternary supertype dynamics #15995

Merged
merged 2 commits into from
May 1, 2024
Merged

fix: Ternary supertype dynamics #15995

merged 2 commits into from
May 1, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented May 1, 2024

close #15975

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (8929395) to head (d9ac875).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/series/mod.rs 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15995      +/-   ##
==========================================
- Coverage   80.95%   80.91%   -0.05%     
==========================================
  Files        1384     1384              
  Lines      178151   178111      -40     
  Branches     3043     3043              
==========================================
- Hits       144229   144115     -114     
- Misses      33439    33513      +74     
  Partials      483      483              
Flag Coverage Δ
python 74.39% <73.68%> (-0.07%) ⬇️
rust 78.04% <73.68%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 80233b8 into main May 1, 2024
25 checks passed
@ritchie46 ritchie46 deleted the unknown branch May 1, 2024 13:31
@mcrumiller
Copy link
Contributor

@ritchie46 did you mean to reference the other issue and not the PR?

@ritchie46
Copy link
Member Author

Ah.. 😂

Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polars hangs for certain math ops inside a when expression
2 participants