Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Decimal supertype for dyn int #16046

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: Decimal supertype for dyn int #16046

merged 1 commit into from
May 4, 2024

Conversation

ritchie46
Copy link
Member

fixes #16035

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (0ed0e8a) to head (5c69546).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16046   +/-   ##
=======================================
  Coverage   80.95%   80.96%           
=======================================
  Files        1386     1386           
  Lines      178386   178385    -1     
  Branches     3064     3060    -4     
=======================================
+ Hits       144421   144423    +2     
+ Misses      33477    33472    -5     
- Partials      488      490    +2     
Flag Coverage Δ
python 74.51% <100.00%> (+0.04%) ⬆️
rust 78.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 4, 2024

CodSpeed Performance Report

Merging #16046 will improve performances by 22.51%

Comparing decimal (5c69546) with main (fd0ae1d)

Summary

⚡ 1 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main decimal Change
test_filter2 2.7 ms 2.2 ms +22.51%

@ritchie46 ritchie46 merged commit e84fe69 into main May 4, 2024
26 checks passed
@ritchie46 ritchie46 deleted the decimal branch May 4, 2024 18:56
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipling a Decimal by Int returns Int type
1 participant