docs(python): Ensure consistent docstring warning in fill_nan methods (pointing out that nan isn't null)
#16061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds (pointing out that it isn't `fill_null`)
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
documentation
alexander-beedie
changed the title
fill_nan methods (pointing out that it isn't fill_null)fill_nan methods (pointing out that nan isn't null)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16061 +/- ##
=======================================
Coverage 80.97% 80.97%
=======================================
Files 1386 1386
Lines 178385 178382 -3
Branches 3060 3059 -1
=======================================
+ Hits 144446 144450 +4
+ Misses 33450 33444 -6
+ Partials 489 488 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Yeap, we keep educating. :) |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…ds (pointing out that `nan` isn't `null`) (pola-rs#16061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16055.
nannot beingnull, but only on the DataFrame/LazyFramefill_nanmethods, not the Expression or Series equivalents - now present on all.Expran explicit part of the typing, since it is supported (and already covered by tests).See Alsosections to further increase visibility.