Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failures in test coverage workflow #16083

Merged
merged 3 commits into from
May 6, 2024
Merged

ci: Fix failures in test coverage workflow #16083

merged 3 commits into from
May 6, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 6, 2024

Changes

  • Refactor the coverage workflow to upload all reports in a single step. This should be more resilient to spurious errors in the upload step.
  • No longer fail the CI if the upload step fails.
  • DO fail the CI if running the tests fails
  • No longer compute coverage in the regular Python test workflow
  • Move codecov.yml to the .github directory

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 6, 2024
@stinodego stinodego changed the title ci: Single coverage upload step, don't fail on error ci: Fix failures in test coverage workflow May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (575e917) to head (74ee7f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #16083    +/-   ##
========================================
  Coverage   80.97%   80.98%            
========================================
  Files        1386     1386            
  Lines      178439   178465    +26     
  Branches     3075     2877   -198     
========================================
+ Hits       144497   144521    +24     
- Misses      33451    33452     +1     
- Partials      491      492     +1     
Flag Coverage Δ
python ?
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review May 6, 2024 17:28
@stinodego stinodego merged commit d1f3ef4 into main May 6, 2024
9 checks passed
@stinodego stinodego deleted the fix-ci-again branch May 6, 2024 17:57
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant