feat(python): Avoid an extra copy when converting Boolean Series to writable NumPy array #16164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ritable NumPy array
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16164 +/- ##
==========================================
+ Coverage 80.95% 81.00% +0.04%
==========================================
Files 1386 1387 +1
Lines 178462 178823 +361
Branches 2881 2877 -4
==========================================
+ Hits 144473 144851 +378
+ Misses 33497 33479 -18
- Partials 492 493 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
May 11, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…ritable NumPy array (pola-rs#16164)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14334
Moving more of the
to_numpyimplementation to Rust. This allows to create writable boolean arrays in one go, rather than casting to u8 and then copying.