Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use zeroable_vec in ewm_mean_by #16166

Merged
merged 1 commit into from
May 12, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented May 11, 2024

@orlp I've tried addressing your suggestion here, fancy taking a look please?

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.00%. Comparing base (172299c) to head (403f8ef).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/polars-ops/src/series/ops/ewm_by.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16166   +/-   ##
=======================================
  Coverage   80.99%   81.00%           
=======================================
  Files        1387     1387           
  Lines      178823   178834   +11     
  Branches     2877     2877           
=======================================
+ Hits       144845   144861   +16     
+ Misses      33486    33481    -5     
  Partials      492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Looks good. 👍 We definitely want to do it in a single pass indeed. Are there more of these @MarcoGorelli?

@ritchie46 ritchie46 merged commit 2f81742 into pola-rs:main May 12, 2024
27 checks passed
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants