refactor: move describe to IR instead of DSL #16191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
github-actions
bot
added
internal
coastalwhite
force-pushed
the
describe-using-ir
branch
from
58b7fe3
to
bf45fb7
Compare
|
There are quite some tests that are failing. I have some trouble running test suite locally, will try to get it to run. |
coastalwhite
force-pushed
the
describe-using-ir
branch
from
bf45fb7
to
110fa35
Compare
coastalwhite
force-pushed
the
describe-using-ir
branch
from
110fa35
to
df3676b
Compare
coastalwhite
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
coastalwhite
force-pushed
the
describe-using-ir
branch
from
df3676b
to
c7a6072
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16191 +/- ##
==========================================
- Coverage 80.99% 80.99% -0.01%
==========================================
Files 1392 1393 +1
Lines 178920 179440 +520
Branches 2892 2907 +15
==========================================
+ Hits 144923 145333 +410
- Misses 33500 33601 +101
- Partials 497 506 +9 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
pushed a commit
to MarcoGorelli/polars
that referenced
this pull request
May 15, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
LazyFrame::describe_optimized_planto using theIRinstead ofDslPlan. Most code is based on the old formatting code and is located in thepolars-plan/src/logical-plan/alp/format.rsfile.