fix(python): Fix some issues in parametric testing with nested dtypes #16211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
changed the title
List types in parametric tests, fix some related issues
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16211 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 1392 1392
Lines 178978 178983 +5
Branches 2907 2908 +1
=======================================
+ Hits 145063 145068 +5
Misses 33409 33409
Partials 506 506 ☔ View full report in Codecov by Sentry. |
stinodego
force-pushed
the
parametric-nested
branch
from
ca8fafc
to
724091e
Compare
MarcoGorelli
pushed a commit
to MarcoGorelli/polars
that referenced
this pull request
May 15, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue, which we should really fix before enabling List types by default:
#16209