Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Add missing support for parsing instantiated Object dtypes Object() #16260

Merged
merged 5 commits into from
May 16, 2024

Conversation

stinodego
Copy link
Member

Also added support for generating object data in parametric tests (but not enabled yet).

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels May 16, 2024
@stinodego stinodego marked this pull request as ready for review May 16, 2024 06:01
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.86%. Comparing base (d7d720a) to head (7eb2e1e).

Files Patch % Lines
py-polars/src/conversion/mod.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16260      +/-   ##
==========================================
- Coverage   80.88%   80.86%   -0.03%     
==========================================
  Files        1394     1394              
  Lines      179488   179490       +2     
  Branches     2913     2913              
==========================================
- Hits       145173   145137      -36     
- Misses      33812    33849      +37     
- Partials      503      504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 0fdc8c7 into main May 16, 2024
17 of 18 checks passed
@stinodego stinodego deleted the parametric-object branch May 16, 2024 06:25
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants