Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Raise import timing test threshold #16302

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

stinodego
Copy link
Member

We should look into the reason behind the failures, e.g. some regression or something with the GitHub runners maybe. Until then I'm upping the threshold to avoid spurious failures.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (10d223b) to head (36fe17b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16302      +/-   ##
==========================================
- Coverage   80.78%   80.78%   -0.01%     
==========================================
  Files        1393     1393              
  Lines      179362   179362              
  Branches     2921     2921              
==========================================
- Hits       144902   144893       -9     
- Misses      33957    33966       +9     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 0eedecc into main May 18, 2024
14 checks passed
@stinodego stinodego deleted the imports-threshold branch May 18, 2024 05:39
@c-peters c-peters added the accepted Ready for implementation label May 21, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants