refactor(python): Very minor refactor of DataFrame.to_numpy code
#16325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16325 +/- ##
==========================================
+ Coverage 81.35% 81.37% +0.01%
==========================================
Files 1403 1403
Lines 183707 183691 -16
Branches 2954 2954
==========================================
+ Hits 149460 149472 +12
+ Misses 33736 33708 -28
Partials 511 511 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
May 20, 2024
py-polars/polars/dataframe/frame.py
Outdated
| @@ -1602,12 +1602,12 @@ def raise_on_copy(msg: str) -> None: | |||
|
|
|||
| out = self._df.to_numpy(order) | |||
| if out is None: | |||
| return np.vstack( | |||
| return np.column_stack( | |||
There was a problem hiding this comment.
I can recall I benchmarked this one. Why do we change from vstack to column_stack and what are the perf implications?
There was a problem hiding this comment.
Let me revert this one for now and look into it more closely - I haven't looked into this too deeply but there are some correctness implications, e.g. currently Array types are not handled correctly. It should not have been included in this PR.
ritchie46
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to take a look at the dataframe code next, starting out with some small refactors.