feat(python): Allow read_excel to handle bytes/BytesIO directly when using the "calamine" (fastexcel) engine
#16344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conjunction with the "calamine" (fastexcel) engine
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
enhancement
alexander-beedie
changed the title
read_excel to handle bytes/BytesIO directly, in conjunction with the "calamine" (fastexcel) engineread_excel to handle bytes/BytesIO directly when using the "calamine" (fastexcel) engine
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16344 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.02%
==========================================
Files 1403 1403
Lines 183750 183754 +4
Branches 2955 2957 +2
==========================================
- Hits 149547 149528 -19
- Misses 33692 33713 +21
- Partials 511 513 +2 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
May 21, 2024
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
…n using the "calamine" (fastexcel) engine (pola-rs#16344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more recent versions of
fastexcel(>= 0.10)1 being able to read bytes data directly; relevant forpl.read_excelwhen the engine is "calamine".Footnotes
https://github.com/ToucanToco/fastexcel/releases/tag/v0.10.0 ↩