Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Fix allocator features #16365

Merged
merged 1 commit into from
May 21, 2024
Merged

build(python): Fix allocator features #16365

merged 1 commit into from
May 21, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 21, 2024

@ritchie46 I expect this to resolve the issue, but I don't really have a good way of testing it except for trying the release again.

I also changed the build features from use_mimalloc and default_allocator to a feature with two possible values allocator = "default" or allocator = "mimalloc". That is not required for the fix but should be a bit more sensible.

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels May 21, 2024
@stinodego stinodego marked this pull request as ready for review May 21, 2024 12:56
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (6289dc3) to head (250c595).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16365      +/-   ##
==========================================
- Coverage   81.38%   81.36%   -0.02%     
==========================================
  Files        1406     1406              
  Lines      183911   183911              
  Branches     2953     2953              
==========================================
- Hits       149671   149647      -24     
- Misses      33727    33751      +24     
  Partials      513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 63f0fcd into main May 21, 2024
20 checks passed
@ritchie46 ritchie46 deleted the fix-alloc-flags branch May 21, 2024 14:07
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants