fixes .list.to_array() with sliced df
#16733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockbeard
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16733 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.01%
==========================================
Files 1413 1413
Lines 186096 186097 +1
Branches 2776 2776
==========================================
- Hits 151588 151572 -16
- Misses 33988 34005 +17
Partials 520 520 ☔ View full report in Codecov by Sentry. |
|
Can confirm this fixes #16693 too |
2 tasks
ritchie46
approved these changes
Jun 5, 2024
|
Thanks a lot! |
Wouittone
pushed a commit
to Wouittone/polars
that referenced
this pull request
Jun 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16540