Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(python): Add future arg to Series.to_arrow #17371

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ruihe774
Copy link
Contributor

@ruihe774 ruihe774 commented Jul 2, 2024

There is a future argument in DataFrame.to_arrow, but it is missing in Series.to_arrow. This PR adds it. Series.to_arrow is used in pyo3-polars, and using future=True significantly improve its performance for e.g. string series.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (120ec7f) to head (cc6d238).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17371      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files        1475     1475              
  Lines      193337   193383      +46     
  Branches     2760     2760              
==========================================
+ Hits       156079   156114      +35     
- Misses      36748    36759      +11     
  Partials      510      510              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 81c05f3 into pola-rs:main Jul 3, 2024
18 checks passed
@stinodego stinodego changed the title perf(python): add future arg to Series.to_arrow perf(python): Add future arg to Series.to_arrow Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants