Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Method dt.truncate was sometimes returning incorrect results for pre-1970 datetimes #17582

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: Method dt.truncate was sometimes returning incorrect results for pre-1970 datetimes #17582

merged 1 commit into from
Jul 12, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

closes #17581

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.47%. Comparing base (aa2c8f1) to head (e0b9f0c).
Report is 277 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17582      +/-   ##
==========================================
+ Coverage   80.44%   80.47%   +0.02%     
==========================================
  Files        1484     1484              
  Lines      195324   195324              
  Branches     2778     2778              
==========================================
+ Hits       157133   157185      +52     
+ Misses      37679    37627      -52     
  Partials      512      512

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli changed the title fix: dt.truncate was sometimes returning incorrect results for pre-1970 datetimes fix: Method dt.truncate was sometimes returning incorrect results for pre-1970 datetimes Jul 11, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 11, 2024
@ritchie46 ritchie46 merged commit a6236c1 into pola-rs:main Jul 12, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.dt.truncate may return incorrect results for pre-1970 dates
2 participants
@MarcoGorelli @ritchie46