fix: Interpret %y consistently with Chrono in to_date/to_datetime/strptime #17661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
github-actions
bot
added
fix
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
reswqa and
orlp
as code owners
MarcoGorelli
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17661 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.01%
==========================================
Files 1485 1485
Lines 195527 195527
Branches 2782 2782
==========================================
- Hits 157839 157821 -18
- Misses 37176 37194 +18
Partials 512 512 ☔ View full report in Codecov by Sentry. |
ritchie46
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17213
Personally I don't think the cutoff should be configurable (for a start, Chrono doesn't make it configurable, so there'd be no way to control what happens when the Chrono parser is used)
The Polars docs already point to the Chrono docs, so I think that's sufficient (I've also made a PR to chrono to note the cutoff in their docs chronotope/chrono#1598)
This is one of those borderline bugfix / breaking changes that I think would be better suited to 1.2 than to 1.1.1. At the same time, I don't think it's significant enough that it warrants waiting until 2.0