fix(python): Address read_database issue with batched reads from Snowflake
#17688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
changed the title
read_database issue with batched reads from Sn…read_database issue with batched reads from Snowflake
github-actions
bot
added
fix
alexander-beedie
force-pushed
the
read-snowflake-batches
branch
from
6eaaf39
to
aa08d00
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17688 +/- ##
==========================================
- Coverage 80.62% 80.47% -0.16%
==========================================
Files 1490 1498 +8
Lines 195995 196459 +464
Branches 2789 2790 +1
==========================================
+ Hits 158030 158098 +68
- Misses 37452 37847 +395
- Partials 513 514 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17404.
Fixes an issue with Arrow-aware drivers that don't support exact batch sizes (so far this only means Snowflake, but the fix is generic). Also allows the same drivers to skip setting a dummy "batch_size" value.