Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Percent encode for Hugging Face paths #17718

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Jul 19, 2024

This allows us to scan paths with special characters from Hugging Face (e.g. datetime-partitioned hive data)

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.39%. Comparing base (235cad3) to head (72da014).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/polars-io/src/path_utils/hugging_face.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17718      +/-   ##
==========================================
+ Coverage   80.37%   80.39%   +0.02%     
==========================================
  Files        1500     1500              
  Lines      196605   196619      +14     
  Branches     2793     2793              
==========================================
+ Hits       158016   158077      +61     
+ Misses      38076    38029      -47     
  Partials      513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review July 19, 2024 06:35
@ritchie46 ritchie46 merged commit f70b7f9 into pola-rs:main Jul 19, 2024
23 checks passed
@nameexhaustion nameexhaustion deleted the hf-datetime branch July 19, 2024 12:22
@c-peters c-peters added the accepted Ready for implementation label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants