Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Batch parquet integer decoding #17734

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jul 19, 2024
@ritchie46
Copy link
Member

Any benchmark numbers? ^^

@coastalwhite
Copy link
Collaborator Author

For single-threaded cold runs:

Benchmark 1: ./plparbench-before
  Time (mean ± σ):     27.046 s ±  0.188 s    [User: 12.426 s, System: 10.449 s]
  Range (min … max):   26.731 s … 27.222 s    5 runs

Benchmark 2: ./plparbench-after
  Time (mean ± σ):     24.166 s ±  0.195 s    [User: 10.760 s, System: 10.243 s]
  Range (min … max):   23.976 s … 24.488 s    5 runs

Summary
  ./plparbench-after ran
    1.12 ± 0.01 times faster than ./plparbench-before

For multi-threaded cold runs the performance gain if any is negledable, since there are other columns that take longer to decode.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (7015663) to head (66e1fb7).

Files Patch % Lines
...quet/src/arrow/read/deserialize/primitive/basic.rs 33.33% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17734   +/-   ##
=======================================
  Coverage   80.43%   80.44%           
=======================================
  Files        1502     1502           
  Lines      197035   197041    +6     
  Branches     2794     2794           
=======================================
+ Hits       158482   158502   +20     
+ Misses      38039    38025   -14     
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4695c4c into pola-rs:main Jul 20, 2024
21 checks passed
@coastalwhite coastalwhite deleted the parquet-int-batch branch July 20, 2024 08:22
@c-peters c-peters added the accepted Ready for implementation label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants