fix(rust,python): Fix GC logic in write_ipc
#17752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17627 changed the logic of
maybe_gc()
, which was used inwrite_ipc()
. GC might not be performed for arrays with multiple references when writing ipc files, which could result in huge files. This PR fixes it.write_ipc()
now decide whether to gc or not based ontotal_bytes_len()
andtotal_buffer_len()
.