Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove tune-cpu for lts-cpu #17912

Merged
merged 1 commit into from
Jul 28, 2024
Merged

build: Remove tune-cpu for lts-cpu #17912

merged 1 commit into from
Jul 28, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@ritchie46 ritchie46 requested a review from c-peters as a code owner July 28, 2024 06:46
@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Jul 28, 2024
@ritchie46
Copy link
Member Author

Failed the release in https://github.com/pola-rs/polars/actions/runs/10125674111/job/28001425564

@ruihe774 any idea what happened?

@ritchie46 ritchie46 merged commit 34ad361 into main Jul 28, 2024
2 checks passed
@ritchie46 ritchie46 deleted the dev branch July 28, 2024 06:48
ritchie46 added a commit that referenced this pull request Jul 28, 2024
ritchie46 added a commit that referenced this pull request Jul 28, 2024
@ruihe774
Copy link
Contributor

ruihe774 commented Jul 28, 2024

Failed the release in https://github.com/pola-rs/polars/actions/runs/10125674111/job/28001425564

@ruihe774 any idea what happened?

The GCC (version 4.8) used by manylinux2014 is too old, which does not accept x86-64-v2 as the value of -mtune. rustc is not affected.

It's ok to remove tune-cpu for polars-lts-cpu, which is for old cpu models and not performance-oriented.

@c-peters c-peters added the accepted Ready for implementation label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants