fix: Incorrect lazy CSV select(len()) for compressed files
#18067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18067 +/- ##
==========================================
- Coverage 80.37% 80.35% -0.02%
==========================================
Files 1496 1496
Lines 197542 197545 +3
Branches 2820 2820
==========================================
- Hits 158771 158735 -36
- Misses 38249 38288 +39
Partials 522 522 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
csv-compressed-count
branch
from
067aea6
to
18dcecf
Compare
nameexhaustion
commented
Aug 7, 2024
crates/polars-io/src/utils/other.rs
Outdated
| @@ -47,9 +47,9 @@ pub fn get_reader_bytes<'a, R: Read + MmapBytesReader + ?Sized>( | |||
| /// | |||
| /// # Safety | |||
| /// The `out` vec outlives `bytes` (declare `out` first). | |||
| pub unsafe fn maybe_decompress_bytes<'a>( | |||
| pub fn maybe_decompress_bytes<'a, 'b: 'a>( | |||
There was a problem hiding this comment.
learned new things about lifetimes recently 😁
There was a problem hiding this comment.
Then we can remove the # Safety comment as well. 👍
There was a problem hiding this comment.
Have removed
actually, now I realize even 'a is enough
nameexhaustion
commented
Aug 7, 2024
| break; | ||
| } | ||
|
|
||
| reader_bytes = &reader_bytes[1..]; |
There was a problem hiding this comment.
skip empty lines at the start
ritchie46
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18057
Fixes #18070