fix: Fix sink_ipc_cloud
panicking with runtime error
#18091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13614
When writing to ObjectStore-compatible storage using the IPC format, it seems like the
block_on
calls inside the constructedCloudWriter
might sometimes get called inside anotherblock_on
call. Tokio does not like this, resulting in a panic.This PR resolves this issue by using
block_on_potential_spawn
in the necessary places instead.This is a fix that was originally written by @Qqwy in another PR: #14262