Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce default async thread count #18142

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

nameexhaustion
Copy link
Collaborator

Work spawned onto tokio threads are generally lightweight I/O tasks that spend most of their time awaiting, so we don't need a lot of threads for it.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 12, 2024
@nameexhaustion nameexhaustion changed the title perf: Reduce async thread count perf: Reduce default async thread count Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (c4c5224) to head (25c53cd).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18142      +/-   ##
==========================================
- Coverage   80.35%   80.33%   -0.03%     
==========================================
  Files        1496     1496              
  Lines      197754   197761       +7     
  Branches     2822     2822              
==========================================
- Hits       158911   158875      -36     
- Misses      38321    38364      +43     
  Partials      522      522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review August 12, 2024 10:57
@ritchie46 ritchie46 merged commit 13ff0e9 into pola-rs:main Aug 12, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
@nameexhaustion nameexhaustion deleted the tokio branch August 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants