-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Consistently round half-way points down in dt.round #18245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18245 +/- ##
==========================================
- Coverage 80.30% 80.24% -0.06%
==========================================
Files 1499 1500 +1
Lines 198744 198889 +145
Branches 2837 2837
==========================================
+ Hits 159604 159606 +2
- Misses 38613 38756 +143
Partials 527 527 ☔ View full report in Codecov by Sentry. |
@@ -5,6 +5,11 @@ use polars_core::prelude::*; | |||
use polars_utils::cache::FastFixedCache; | |||
|
|||
use crate::prelude::*; | |||
use crate::truncate::fast_truncate; | |||
|
|||
fn fast_round(t: i64, every: i64) -> i64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you tag this with inline(always)
?
closes #18239