Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Expose many more function expressions to python IR #18317

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

wence-
Copy link
Collaborator

@wence- wence- commented Aug 22, 2024

This covers the remaining "easy" ones where we just need to pass names and some trivial information through.

This covers the remaining "easy" ones where we just need to pass names
and some trivial information through.
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (9833887) to head (91c500c).
Report is 7 commits behind head on main.

Files Patch % Lines
.../polars-python/src/lazyframe/visitor/expr_nodes.rs 0.00% 61 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18317      +/-   ##
==========================================
- Coverage   80.35%   80.32%   -0.04%     
==========================================
  Files        1501     1501              
  Lines      199214   199262      +48     
  Branches     2837     2837              
==========================================
- Hits       160087   160065      -22     
- Misses      38599    38671      +72     
+ Partials      528      526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 0a5bb42 into pola-rs:main Aug 23, 2024
22 checks passed
@wence- wence- deleted the wence/fea/pyexpr-ir-uops branch August 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants