fix: Parquet nested values that span several pages #18407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pola-rs#18400. This completely rewrites the logic that deal with decoding filtered nested values. This was needed to accommodate the fact that any kind of row value might span several data pages. This was not really accounted for in the previous implementation and where it worked, it was mostly by coincidence. This also made it possible to add many fast paths for the decoder that were previously not there. Therefore, I think there is also some performance improvements here, but I am not sure how much. I also wrote two tests to make sure that it actually works.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18407 +/- ##
==========================================
+ Coverage 79.87% 79.93% +0.06%
==========================================
Files 1495 1495
Lines 200199 200272 +73
Branches 2867 2867
==========================================
+ Hits 159905 160096 +191
+ Misses 39748 39630 -118
Partials 546 546 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18400.
This completely rewrites the logic that deal with decoding filtered nested values. This was needed to accommodate the fact that any kind of row value might span several data pages. This was not really accounted for in the previous implementation and where it worked, it was mostly by coincidence.
This also made it possible to add many fast paths for the decoder that were previously not there. Therefore, I think there are also some performance improvements here, but I am not sure how much.
I also wrote two tests to make sure that it actually works.