refactor(rust): Unify internal string type #18425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
commented
Aug 28, 2024
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct PlSmallStr(CompactString); | ||
|
|
||
| impl PlSmallStr { |
orlp
requested changes
Aug 28, 2024
| } | ||
| } | ||
|
|
||
| impl AsRef<str> for PlSmallStr { |
There was a problem hiding this comment.
Can you add AsRef<Path> and AsRef<[u8]>?
crates/polars-utils/src/pl_str.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl From<String> for PlSmallStr { |
There was a problem hiding this comment.
Can you also add FromIterator<T> for at least char, String and &'a str?
nameexhaustion
force-pushed
the
pl-str
branch
2 times, most recently
from
ea4f56f
to
2c5332e
Compare
nameexhaustion
changed the title
github-actions
bot
added
internal
nameexhaustion
commented
Aug 29, 2024
| with_columns = Some(Arc::from(columns)); | ||
| Some(name.clone()) | ||
| }) | ||
| .collect::<Arc<[_]>>(), |
There was a problem hiding this comment.
drive-by refactored
nameexhaustion
commented
Aug 29, 2024
nameexhaustion
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18425 +/- ##
==========================================
- Coverage 79.86% 79.84% -0.02%
==========================================
Files 1496 1497 +1
Lines 200364 201825 +1461
Branches 2867 2867
==========================================
+ Hits 160012 161155 +1143
- Misses 39806 40124 +318
Partials 546 546 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
coastalwhite
as code owners
|
Will address remaining review points in follow-up PRs |
r-brink
pushed a commit
to r-brink/polars
that referenced
this pull request
Aug 29, 2024
wence-
added a commit
to wence-/polars
that referenced
this pull request
Sep 2, 2024
The merge of pola-rs#18425 accidentally reset this to 1.5.
wence-
added a commit
to wence-/polars
that referenced
this pull request
Sep 2, 2024
The merge of pola-rs#18425 accidentally reset this to 1.5.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column names, various field names, DSL / IR fields, timezone strings, etc.
Notes:
arg: PlSmallStr- this is our owned string type, which we pass to functions that internally do things like e.g.ca.with_name(arg).arg: &PlSmallStr- micro-optimization for functions that don't always clone, this is very rare - usually&stris used insteadarg: &str- the usual rust function that doesn't need owned strings, call-sites to these functions that haves: PlSmallStrs will often uses.as_str().